Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only split the signed message in to 2 parts with the message verifier #1596

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1595

Description

In rare cases, the generated data can contain the -- sequence in it. If it does, this PR ensures that the string will only ever be split in to 2 parts. The first part is the data, and the second part is the digest.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink
Copy link
Member Author

hmm 🤔 not sure why nightly is failing now... I hope that doesn't mean some sort of breaking change coming up..

@jwoertink jwoertink merged commit b30040a into master Oct 29, 2021
@jwoertink jwoertink deleted the issues/1595 branch October 29, 2021 15:03
@jwoertink
Copy link
Member Author

Thanks for all of the reviews @matthewmcgarvey!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message Verifier fails when data has --
2 participants