fix input for local_cache.get in S3Client.get_tasks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kohei-shinden Cool! Thx for very detailed issue report and this subsequent PR ! @hirosassa @vaaaaanquish Plz take a look at this changes :) |
Hi-king
approved these changes
Feb 1, 2022
|
Looks Great! |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
詳細は #47 において説明しています。
以下の 2 箇所の入力について修正を行いました。
thunderbolt/thunderbolt/client/s3_client.py
Line 36 in 322af39
thunderbolt/thunderbolt/client/s3_client.py
Line 51 in 322af39
Close #47