Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: S3Client.get_tasks #50

Merged
merged 1 commit into from
May 12, 2022
Merged

Fix: S3Client.get_tasks #50

merged 1 commit into from
May 12, 2022
+2 −2

Conversation

yuta100101
Copy link
Contributor

In recent version(0.1.1), S3Client.get_tasks() doesn't work because the commit in #48 includes a minor mistake.

not "key", but "Key" is correct for x's key.

            if self.use_cache:
                cache = self.local_cache.get(x['key'])
                if cache:
                    tasks_list.append(cache)
                    continue

This fix makes get_tasks work properly.

related issue: #47

Hi-king
Hi-king approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@Hi-king Hi-king left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. @yuta100101 Thank you for your contribution!

@Hi-king Hi-king merged commit cc31d7c into m3dev:master May 12, 2022
@yuta100101
Copy link
Contributor Author

Thank you for quick response!

@yuta100101 yuta100101 deleted the fix/s3_client_get_tasks branch May 17, 2022 06:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Hi-king Hi-king Hi-king approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuta100101 @Hi-king