Skip to content

Commit

Permalink
[dev]: Update PR template for danger checks (and update danger) (#1269)
Browse files Browse the repository at this point in the history
* ci: Add danger back to repo

* Use labels plugin to automatically add labels from checkbox

* working label validation

* Update readme

* Push to trigger

* another push

* Use my fork of labels plugin

* Add more validation functions, update pr template, and remove unused plugin

* Update yarn lock

* Add checks for todos, missing sections

* Fix the testing header and check for any header level

* small changes and comment removal

* commit to check to see what envs codebuild has

* Add message for when no issue is found

* cleanup

* Add a failing test to check something with codebuild + danger

* Deleting dangerfile -- will be maintained in cicd repo

* Undo changes to testfile
  • Loading branch information
sirugh authored and dpatil-magento committed Jun 5, 2019
1 parent a99702e commit 7832d03
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
7 changes: 4 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ Feel free to remove this section before creating this PR. Thank you for your con
-->

## Description
<!--- Describe your changes in detail here -->
TODO: Describe your changes in detail here.

## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here with the specific wording: "Closes #<issue>" -->
<!--- Please link to the issue here by replacing ISSUE_NUMBER with your actual issue number. -->
<!--- Using the above wording causes Github to automatically close the issue on merge. -->
Closes #ISSUE_NUMBER.

Expand All @@ -27,10 +27,11 @@ Closes #ISSUE_NUMBER.
2. Verify the BAR shows up.
3. Make sure BAZ does a thing.

## How Have YOU Tested this?
## How have YOU tested this?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
TODO: Please describe in detail how you tested your changes.

## Screenshots / Screen Captures (if appropriate):

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"chokidar": "~2.1.2",
"concurrently": "^4.1.0",
"coveralls": "~3.0.3",
"danger": "~7.0.17",
"danger": "^7.1.4",
"eslint": "~5.14.1",
"eslint-plugin-babel": "~5.3.0",
"eslint-plugin-graphql": "~3.0.3",
Expand Down
15 changes: 11 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5913,10 +5913,10 @@ damerau-levenshtein@^1.0.4:
resolved "https://registry.yarnpkg.com/damerau-levenshtein/-/damerau-levenshtein-1.0.4.tgz#03191c432cb6eea168bb77f3a55ffdccb8978514"
integrity sha1-AxkcQyy27qFou3fzpV/9zLiXhRQ=

danger@~7.0.17:
version "7.0.19"
resolved "https://registry.yarnpkg.com/danger/-/danger-7.0.19.tgz#aa3d976fc7bfa616e1537ad8951c0d13f0a1c42d"
integrity sha512-vqV3kF71asWTxa/YvOfDg379SS20MwAp33uoHKz+hcd8zlmLSpA90V+ZonNsNbQkbsuTTjQGtLVlGVBVezL5DA==
danger@^7.1.4:
version "7.1.4"
resolved "https://registry.yarnpkg.com/danger/-/danger-7.1.4.tgz#de068b9277143505a7aaa698f27aac90c00303ae"
integrity sha512-Q6Qi7GZ58k2kyGbZkToGquM8ELtY9GR2CsfHeKGzIa77cRzaTMvn/x1W4FH3Vd0WPIASDV1yFp0xjvbK9sPcpg==
dependencies:
"@babel/polyfill" "^7.2.5"
"@octokit/rest" "^16.14.1"
Expand All @@ -5935,8 +5935,10 @@ danger@~7.0.17:
lodash.includes "^4.3.0"
lodash.isobject "^3.0.2"
lodash.keys "^4.0.8"
lodash.mapvalues "^4.6.0"
lodash.memoize "^4.1.2"
memfs-or-file-map-to-github-branch "^1.1.0"
micromatch "^3.1.10"
node-cleanup "^2.1.2"
node-fetch "^2.3.0"
override-require "^1.1.1"
Expand Down Expand Up @@ -10584,6 +10586,11 @@ lodash.keysin@^3.0.0:
lodash.isarguments "^3.0.0"
lodash.isarray "^3.0.0"

lodash.mapvalues@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.mapvalues/-/lodash.mapvalues-4.6.0.tgz#1bafa5005de9dd6f4f26668c30ca37230cc9689c"
integrity sha1-G6+lAF3p3W9PJmaMMMo3IwzJaJw=

lodash.memoize@^4.1.2:
version "4.1.2"
resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-4.1.2.tgz#bcc6c49a42a2840ed997f323eada5ecd182e0bfe"
Expand Down

1 comment on commit 7832d03

@vercel
Copy link

@vercel vercel bot commented on 7832d03 Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please # to comment.