-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[dev]: Update PR template for danger checks (and update danger) #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically deployed with Now. Latest deployment for this branch: https://venia-git-dangerlabel.magento-research1.now.sh |
dpatil-magento
approved these changes
Jun 4, 2019
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some tooling around the contents of PR as in the labels, description, etc:
Related Issue
Closes #1279 .
Verification Steps
yarn install
.danger pr https://github.com/magento-research/pwa-studio/pull/1269
or replace the PR link with some other PR you want to test.Closes #<ISSUE_NUMBER>
.#ISSUE_NUMBER
with a closed issue.packages
directories.How have YOU tested this?
Tested locally with
danger pr https://github.com/magento-research/pwa-studio/pull/1269
Proposed Labels for Change Type/Package
Checklist: