Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dev]: Update PR template for danger checks (and update danger) #1269

Merged
merged 23 commits into from
Jun 5, 2019

Conversation

sirugh
Copy link
Contributor

@sirugh sirugh commented May 24, 2019

Description

Adding some tooling around the contents of PR as in the labels, description, etc:

  • Made some small changes to the PR template.
  • Updated dangerfile for checking PR labels, description and other rules we want to apply to the pull request metadata rather than the code changes.
  • Trigger that job hourly since AWS CodeBuild doesn't allow usage of Github's PR Edit webhooks (currently they only have create/update/reopen).

Related Issue

Closes #1279 .

Verification Steps

  1. Check out the PR and yarn install.
  2. Run danger pr https://github.com/magento-research/pwa-studio/pull/1269 or replace the PR link with some other PR you want to test.
  3. See results in your console.
  4. To test each failure, open your own PR and:
  • Add a TODO in the description somewhere
  • Delete a section header completely.
  • Leave one of the sections as the default text like Closes #<ISSUE_NUMBER>.
  • After the above, replace #ISSUE_NUMBER with a closed issue.
  • Do not apply a version label.
  • Check that appropriate project labels are applied (should apply on changes to code within the packages directories.

How have YOU tested this?

Tested locally with danger pr https://github.com/magento-research/pwa-studio/pull/1269

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@vercel
Copy link

vercel bot commented May 24, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://venia-git-dangerlabel.magento-research1.now.sh

@vercel vercel bot temporarily deployed to staging May 24, 2019 20:53 Inactive
@vercel vercel bot temporarily deployed to staging May 24, 2019 20:55 Inactive
@sirugh sirugh added version: Patch This changeset includes backwards compatible bug fixes. version: Minor This changeset includes functionality added in a backwards compatible manner. and removed version: Patch This changeset includes backwards compatible bug fixes. labels May 24, 2019
@sirugh sirugh added pkg:venia-concept and removed pkg:venia-concept version: Minor This changeset includes functionality added in a backwards compatible manner. labels May 28, 2019
@sirugh sirugh self-assigned this May 28, 2019
@sirugh sirugh added version: Minor This changeset includes functionality added in a backwards compatible manner. and removed version: Minor This changeset includes functionality added in a backwards compatible manner. labels May 28, 2019
@sirugh sirugh changed the title ci: Add danger back to repo with updated rules WIP: Create dangerfile to test pr meta data May 29, 2019
@vercel vercel bot temporarily deployed to staging June 3, 2019 17:45 Inactive
@sirugh sirugh changed the title WIP: Create dangerfile to test pr meta data WIP: Update PR template for danger checks (and update danger) Jun 3, 2019
@sirugh sirugh changed the title WIP: Update PR template for danger checks (and update danger) [dev]: Update PR template for danger checks (and update danger) Jun 3, 2019
@sirugh sirugh requested a review from dpatil-magento June 3, 2019 18:01
@dpatil-magento dpatil-magento mentioned this pull request Jun 5, 2019
5 tasks
@dpatil-magento dpatil-magento added version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. and removed version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. labels Jun 5, 2019
@dpatil-magento dpatil-magento merged commit 7832d03 into develop Jun 5, 2019
@sirugh sirugh deleted the danger_label branch July 25, 2019 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Danger CI tooling to automate initial github PR/issue checks
2 participants