Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PWA-3283-v2: Adding i18n file path in watch-all.js #4269

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

glo11372
Copy link
Contributor

@glo11372 glo11372 commented May 21, 2024

Description

  1. To watch the changes run “yarn run watch:all”
  2. Also in watch-all.js added file path of venia-ui/i18n so that watch-all.js can detect changes

Related Issue

Closes #3134

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes. pkg:venia-ui labels May 21, 2024
@glo11372 glo11372 requested a review from glo82145 May 21, 2024 10:44
@glo11372 glo11372 self-assigned this May 21, 2024
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 Missing "Description" section. Please add it back, with detail.
Messages
📖

Associated JIRA tickets: PWA-3283.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 1766429

@glo82145 glo82145 merged commit cd0adbc into develop Jun 4, 2024
6 of 8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Storefront needs to automatically update the newly added/changes translations
3 participants