Add geocoder #785
Closed
Add geocoder #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrelsford
commented
Aug 12, 2022
| @@ -687,7 +687,9 @@ export default class App extends React.Component { | |||
| options={this.state.mapboxGlDebugOptions} | |||
| inspectModeEnabled={this.state.mapState === "inspect"} | |||
| highlightedLayer={this.state.mapStyle.layers[this.state.selectedLayerIndex]} | |||
| onLayerSelect={this.onLayerSelect} /> | |||
| onLayerSelect={this.onLayerSelect} | |||
| showGeocoder={true} | |||
There was a problem hiding this comment.
Do we always want to show it? Only when there's a valid Mapbox API key?
There was a problem hiding this comment.
Hi @ebrelsford, thanks for your PR but I think would should not include the Mapbox geocoder at all because of the Mapbox Geocoding API terms:
4.1. In General. You may not use Geocodes: [...] (b) to develop any general
purpose printed or digital map (of any geographic size)
And developing a map is what Maputnik is used for :)
|
@ebrelsford any chance you can rework this PR to add maplibre geocoder with nominatim? |
|
Closed in favor of: |
HarelM
added a commit
that referenced
this pull request
Feb 4, 2024
This replaces PR: - #785 Before:  After:  This is based on the geocoder example in maplibre docs: https://maplibre.org/maplibre-gl-js/docs/examples/geocoder/
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Mapbox GL geocoder to the map controls.
To do: