Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add nominatim search to maputnik #873

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Add nominatim search to maputnik #873

merged 2 commits into from
Feb 4, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Feb 4, 2024

This replaces PR:

Before:
image
After:
image

This is based on the geocoder example in maplibre docs:
https://maplibre.org/maplibre-gl-js/docs/examples/geocoder/

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6f82c12) 56.94% compared to head (0b26fc8) 56.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/MapMaplibreGl.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   56.94%   56.78%   -0.16%     
==========================================
  Files         104      104              
  Lines        2922     2939      +17     
  Branches      670      670              
==========================================
+ Hits         1664     1669       +5     
- Misses       1258     1270      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM mentioned this pull request Feb 4, 2024
1 task
@HarelM HarelM requested a review from nyurik February 4, 2024 09:01
@HarelM HarelM merged commit cb77c6b into main Feb 4, 2024
7 checks passed
@HarelM HarelM deleted the geo-coder branch February 4, 2024 09:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants