Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix circular import TrainModelHandler <> PricecypherModel #53

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

marijnvanderhorst
Copy link
Member

Proposed changes

  1. The pricecypher.contracts model imports both TrainModelHandler and PricecypherModel during __init__.
  2. The TrainModelHandler model imports PricecypherModel form pricecypher.contracts
  3. Which in turn makes the pricecypher.contracts model import the TrainModelHandler again.

Types of changes

What types of changes does your code introduce to this repository?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

Unit testing

n/a

Manual testing

Use TrainModelHandler somewhere (just importing it should be enough)

Further comments

n/a

@marijnvanderhorst marijnvanderhorst requested a review from a team as a code owner December 3, 2024 08:38
Copy link

snyk-io-eu bot commented Dec 3, 2024

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@marijnvanderhorst marijnvanderhorst merged commit fb1886d into develop Dec 3, 2024
4 checks passed
@marijnvanderhorst marijnvanderhorst deleted the bugfix/circular-import branch December 3, 2024 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants