Release v3.5.1 to master #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed changes 1. The `pricecypher.contracts` model imports both `TrainModelHandler` and `PricecypherModel` during `__init__`. 2. The `TrainModelHandler` model imports `PricecypherModel form pricecypher.contracts` 3. Which in turn makes the `pricecypher.contracts` model import the `TrainModelHandler` again. ## Types of changes What types of changes does your code introduce to this repository? - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Testing ### Unit testing n/a ### Manual testing Use `TrainModelHandler` somewhere (just importing it should be enough) ## Further comments n/a
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
JorisMarcelis
approved these changes
Dec 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Merge using fast-forward!
v3.5.1
TrainModelHandler<>PricecypherModel#53