Skip to content

Commit

Permalink
Resolved issue regarding openign boards link from channels (#1388)
Browse files Browse the repository at this point in the history
* Resolved issue regarding openign boards link from channels

* Removed unnecessary check
  • Loading branch information
harshilsharma63 authored Oct 4, 2021
1 parent 17991b9 commit 7ce9e44
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions webapp/src/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ const App = React.memo((): JSX.Element => {
dispatch(fetchLanguage())
dispatch(fetchMe())
dispatch(fetchClientConfig())
history.replace(window.location.pathname.replace((window as any).frontendBaseURL, ''))
}, [])

useEffect(() => {
Expand All @@ -106,8 +107,8 @@ const App = React.memo((): JSX.Element => {
setTimeout(() => dispatch(setGlobalError('')), 0)
}

const continueToWelcomeScreen = (boardIdIsValidUUIDV4 = true) => {
return Utils.isFocalboardPlugin() && loggedIn === true && (!UserSettings.welcomePageViewed || !boardIdIsValidUUIDV4)
const continueToWelcomeScreen = () => {
return Utils.isFocalboardPlugin() && loggedIn === true && !UserSettings.welcomePageViewed
}

const buildOriginalPath = (workspaceId = '', boardId = '', viewId = '', cardId = '') => {
Expand Down Expand Up @@ -231,7 +232,7 @@ const App = React.memo((): JSX.Element => {
return <Redirect to='/#'/>
}

if (continueToWelcomeScreen(boardIdIsValidUUIDV4)) {
if (continueToWelcomeScreen()) {
const originalPath = `/${buildOriginalPath('', boardId, viewId, cardId)}`
const queryString = boardIdIsValidUUIDV4 ? `r=${originalPath}` : ''
return <Redirect to={`/welcome?${queryString}`}/>
Expand Down

0 comments on commit 7ce9e44

Please # to comment.