Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Resolved issue regarding openign boards link from channels #1388

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

harshilsharma63
Copy link
Member

Summary

Resolves the issue of opening Boards via a link in Channels.

Ticket Link

Fixes #1373

@harshilsharma63 harshilsharma63 requested a review from a team as a code owner October 1, 2021 10:15
webapp/src/app.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tiny change needed, otherwise, looks good to me.

Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Fixes the problem I had with VALIDUUID check as well.

@harshilsharma63 harshilsharma63 merged commit 7ce9e44 into main Oct 4, 2021
@harshilsharma63 harshilsharma63 deleted the channels-to-boards-navigation-fix branch October 4, 2021 09:14
harshilsharma63 added a commit that referenced this pull request Oct 4, 2021
* Resolved issue regarding openign boards link from channels

* Removed unnecessary check
@harshilsharma63 harshilsharma63 added 3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone labels Oct 4, 2021
@hahmadia hahmadia removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Opening URL to board sometimes opens Dashboard instead
3 participants