Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates samples to use version 0.4.0 #55

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Updates samples to use version 0.4.0 #55

merged 4 commits into from
Sep 10, 2020

Conversation

kdenhartog
Copy link
Contributor

Description

Updates samples to use version 0.4.0

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Addresses issue #49 and #50

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

The API changed on the samples from being strings of messages to being Uint8Array of messages.
Additionally the type for nonce was changed from string to Uint8Array. This update supports the new
API as of v0.4.0

re #50
This locks the sample for bbs-signatures in a browser to be specific to v0.4.0 now

re #49
@tplooker tplooker merged commit f8fa318 into master Sep 10, 2020
@tplooker tplooker deleted the kdh/update-samples branch September 10, 2020 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants