Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci(presubmit): Fixes several quality of life issues in presubmit workflow #1306

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

melink14
Copy link
Owner

@melink14 melink14 commented Dec 4, 2022

  • Migrates to new set-output syntax to avoid deprecation warning.
  • Marks fetch: false when adding commits for significant speed up.
  • Excludes /screenshots directory when commiting lint fixes. This avoid inadvertantly committing failed screenshot metadata when visual regression tests fail. (Requiring a manual revert)

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
See EndBug/add-and-commit#386

…flow

- Migrates to new `set-output` syntax to avoid deprecation warning.
- Marks `fetch: false` when adding commits for significant speed up.
- Excludes /screenshots directory when commiting lint fixes. This avoid inadvertantly committing failed screenshot metadata when visual regression tests fail. (Requiring a manual revert)

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
See EndBug/add-and-commit#386
@melink14 melink14 added the self-approved Label which allows mergify to approve owner's PRs label Dec 4, 2022
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

melink14 says it's fine so it must be fine!

@mergify mergify bot merged commit 51ea7e4 into main Dec 5, 2022
@mergify mergify bot deleted the melink14/update-presubmit branch December 5, 2022 00:02
@melink14
Copy link
Owner Author

melink14 commented Dec 5, 2022

🎉 This PR is included in version 2.4.30 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
released self-approved Label which allows mergify to approve owner's PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant