Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci(presubmit): Fixes several quality of life issues in presubmit workflow #1306

Merged
merged 2 commits into from
Dec 5, 2022
Merged

ci(presubmit): Fixes several quality of life issues in presubmit workflow #1306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f434b81
ci(presubmit): Fixes several quality of life issues in presubmit work…
melink14 Dec 4, 2022
0b3af13
Merge branch 'main' into melink14/update-presubmit
melink14 Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Check for screenshot failures
id: check-screenshots
if: failure()
run: echo "::set-output name=screenshot_failure::$(ls -1 screenshots/Chromium/failed | wc -l)"
run: echo "screenshot_failure=$(ls -1 screenshots/Chromium/failed | wc -l)" >> $$GITHUB_OUTPUT
- name: Upload failing screenshots and diffs
uses: actions/upload-artifact@v3
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0
Expand All @@ -57,6 +57,7 @@ jobs:
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0 && github.event_name == 'pull_request'
with:
message: 'test(visual): Update baselines with new screenshots'
fetch: false
add: 'screenshots/Chromium/baseline/*.png'
default_author: github_actions
- name: Try to fix lint errors
Expand All @@ -67,7 +68,8 @@ jobs:
if: failure() && github.event_name == 'pull_request'
with:
message: 'style: Fix lint/formatting errors'
add: '.'
fetch: false
add: . -- ':!screenshots'
default_author: github_actions
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
Expand Down