Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type #2732

Merged
merged 14 commits into from
Nov 6, 2024

Conversation

@edgarrmondragon edgarrmondragon changed the title feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type Oct 25, 2024
@edgarrmondragon edgarrmondragon added Needs Documentation Release Highlight Call this out in the release notes labels Oct 25, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 25, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 25, 2024
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #2732 will not alter performance

Comparing edgarrmondragon/feat/jsonschema-to-sql (dea21ae) with main (2ad977e)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (2ad977e) to head (dea21ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
+ Coverage   90.71%   90.80%   +0.08%     
==========================================
  Files          62       62              
  Lines        5021     5089      +68     
  Branches      641      658      +17     
==========================================
+ Hits         4555     4621      +66     
- Misses        324      326       +2     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit de7d1dc into main Nov 6, 2024
38 of 39 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/jsonschema-to-sql branch November 6, 2024 23:05
edgarrmondragon added a commit to MeltanoLabs/target-postgres that referenced this pull request Nov 7, 2024
edgarrmondragon added a commit that referenced this pull request Nov 11, 2024
… mapping from JSON schema to SQL column type (#2732)

* feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type

* Add failing test for complex type case

* Correctly handle multiple types

* Make mypy happy

* Test more cases

* Add docs

* Fix annotation in docs

* Support custom fallbacks

* Add a way to customize raw string handling
edgarrmondragon added a commit that referenced this pull request Nov 27, 2024
… schemas (#2566)

* refactor: Standardize on JSON Schema Draft 2020-12 to validate stream schemas

* chore(deps): bump pip from 24.2 to 24.3.1 in /.github/workflows in the ci group (#2733)

chore(deps): bump pip in /.github/workflows in the ci group

Bumps the ci group in /.github/workflows with 1 update: [pip](https://github.com/pypa/pip).


Updates `pip` from 24.2 to 24.3.1
- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)
- [Commits](pypa/pip@24.2...24.3.1)

---
updated-dependencies:
- dependency-name: pip
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ci
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: Test `parquet` extra on Python 3.13 (#2734)

* test: Test `parquet` extra on Python 3.13

* Remove xfails

* chore: pre-commit autoupdate (#2735)

* chore: pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.1](astral-sh/ruff-pre-commit@v0.7.0...v0.7.1)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* packaging: Skip `simpleeval` 1.0.1 (#2736)

* chore(deps): bump pypa/gh-action-pypi-publish from 1.10.3 to 1.11.0 in the actions group (#2737)

chore(deps): bump pypa/gh-action-pypi-publish in the actions group

Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish).


Updates `pypa/gh-action-pypi-publish` from 1.10.3 to 1.11.0
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.3...v1.11.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Run `poetry lock` (#2738)

* chore: pre-commit autoupdate (#2740)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.1 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.1...v0.7.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: `datetime.datetime` instances in stream maps are now correctly mapped to `date-time` JSON schema strings (#2741)

fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings

* feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type (#2732)

* feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type

* Add failing test for complex type case

* Correctly handle multiple types

* Make mypy happy

* Test more cases

* Add docs

* Fix annotation in docs

* Support custom fallbacks

* Add a way to customize raw string handling

* feat(templates): Update dependencies in templates (#2742)

* refactor: Deprecate passing file paths to plugin and stream initialization (#2743)

* docs: Document the current release process (#2745)

* chore: Update issue types in templates

* ci: Run tests on `v*` branches (#2747)

* chore(deps): bump the actions group with 2 updates (#2748)

Bumps the actions group with 2 updates: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) and [commitizen-tools/commitizen-action](https://github.com/commitizen-tools/commitizen-action).


Updates `pypa/gh-action-pypi-publish` from 1.11.0 to 1.12.2
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.11.0...v1.12.2)

Updates `commitizen-tools/commitizen-action` from 0.21.0 to 0.22.0
- [Release notes](https://github.com/commitizen-tools/commitizen-action/releases)
- [Changelog](https://github.com/commitizen-tools/commitizen-action/blob/master/CHANGELOG.md)
- [Commits](commitizen-tools/commitizen-action@0.21.0...0.22.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: commitizen-tools/commitizen-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Release v0.42.0 (#2749)

* chore: Bump package version

* Update dev deps

---------

Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com>
Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>

* refactor: Dropped support for Python 3.8 (#2751)

* refactor: Dropped support for Python 3.8

* Update tests/core/test_connector_sql.py

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: MeltyBot <105875157+MeltyBot@users.noreply.github.com>
nickjoanis pushed a commit to rosecape/target-postgres that referenced this pull request Dec 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Documentation Release Highlight Call this out in the release notes
Projects
Status: Discussed
Development

Successfully merging this pull request may close these issues.

1 participant