Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: datetime.datetime instances in stream maps are now correctly mapped to date-time JSON schema strings #2741

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: datetime.datetime instances in stream maps are now correctly mapped to date-time JSON schema strings #2741

merged 1 commit into from
Nov 6, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 6, 2024 •
edited by github-actions bot
Loading

@edgarrmondragon edgarrmondragon linked an issue Nov 6, 2024 that may be closed by this pull request
bug: CustomStreamMap always convert datetime field to date #2739
Closed
1 task
@edgarrmondragon edgarrmondragon changed the title fix: datetime.datetime instances are correctly mapped to date-time JSON schema strings fix: datetime.datetime instances are now correctly mapped to date-time JSON schema strings Nov 6, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 6, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Nov 6, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #2741 will not alter performance

Comparing 2739-bug-customstreammap-always-convert-datetime-field-to-date (e1e7988) with main (5bb2d85)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon changed the title fix: datetime.datetime instances are now correctly mapped to date-time JSON schema strings fix: datetime.datetime instances in stream maps are now correctly mapped to date-time JSON schema strings Nov 6, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (ce6941f) to head (e1e7988).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2741   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          62       62           
  Lines        5021     5021           
  Branches      641      641           
=======================================
  Hits         4553     4553           
  Misses        326      326           
  Partials      142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 2ad977e into main Nov 6, 2024
40 checks passed
@edgarrmondragon edgarrmondragon deleted the 2739-bug-customstreammap-always-convert-datetime-field-to-date branch November 6, 2024 18:27
edgarrmondragon added a commit that referenced this pull request Nov 11, 2024
@edgarrmondragon
fix: datetime.datetime instances in stream maps are now correctly m…
2510d9e 
…apped to `date-time` JSON schema strings (#2741)

fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings
edgarrmondragon added a commit that referenced this pull request Nov 27, 2024
@edgarrmondragon @dependabot
@pre-commit-ci @MeltyBot
refactor: Standardize on JSON Schema Draft 2020-12 to validate stream…
b425274 
… schemas (#2566)

* refactor: Standardize on JSON Schema Draft 2020-12 to validate stream schemas

* chore(deps): bump pip from 24.2 to 24.3.1 in /.github/workflows in the ci group (#2733)

chore(deps): bump pip in /.github/workflows in the ci group

Bumps the ci group in /.github/workflows with 1 update: [pip](https://github.com/pypa/pip).


Updates `pip` from 24.2 to 24.3.1
- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)
- [Commits](pypa/pip@24.2...24.3.1)

---
updated-dependencies:
- dependency-name: pip
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ci
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: Test `parquet` extra on Python 3.13 (#2734)

* test: Test `parquet` extra on Python 3.13

* Remove xfails

* chore: pre-commit autoupdate (#2735)

* chore: pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.1](astral-sh/ruff-pre-commit@v0.7.0...v0.7.1)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* packaging: Skip `simpleeval` 1.0.1 (#2736)

* chore(deps): bump pypa/gh-action-pypi-publish from 1.10.3 to 1.11.0 in the actions group (#2737)

chore(deps): bump pypa/gh-action-pypi-publish in the actions group

Bumps the actions group with 1 update: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish).


Updates `pypa/gh-action-pypi-publish` from 1.10.3 to 1.11.0
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.10.3...v1.11.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Run `poetry lock` (#2738)

* chore: pre-commit autoupdate (#2740)

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.1 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.1...v0.7.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: `datetime.datetime` instances in stream maps are now correctly mapped to `date-time` JSON schema strings (#2741)

fix: `datetime.datetime` instances are correctly mapped to `date-time` JSON schema strings

* feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type (#2732)

* feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type

* Add failing test for complex type case

* Correctly handle multiple types

* Make mypy happy

* Test more cases

* Add docs

* Fix annotation in docs

* Support custom fallbacks

* Add a way to customize raw string handling

* feat(templates): Update dependencies in templates (#2742)

* refactor: Deprecate passing file paths to plugin and stream initialization (#2743)

* docs: Document the current release process (#2745)

* chore: Update issue types in templates

* ci: Run tests on `v*` branches (#2747)

* chore(deps): bump the actions group with 2 updates (#2748)

Bumps the actions group with 2 updates: [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) and [commitizen-tools/commitizen-action](https://github.com/commitizen-tools/commitizen-action).


Updates `pypa/gh-action-pypi-publish` from 1.11.0 to 1.12.2
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.11.0...v1.12.2)

Updates `commitizen-tools/commitizen-action` from 0.21.0 to 0.22.0
- [Release notes](https://github.com/commitizen-tools/commitizen-action/releases)
- [Changelog](https://github.com/commitizen-tools/commitizen-action/blob/master/CHANGELOG.md)
- [Commits](commitizen-tools/commitizen-action@0.21.0...0.22.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: commitizen-tools/commitizen-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: Release v0.42.0 (#2749)

* chore: Bump package version

* Update dev deps

---------

Co-authored-by: edgarrmondragon <16805946+edgarrmondragon@users.noreply.github.com>
Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>

* refactor: Dropped support for Python 3.8 (#2751)

* refactor: Dropped support for Python 3.8

* Update tests/core/test_connector_sql.py

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: MeltyBot <105875157+MeltyBot@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
Stream Maps
Projects
None yet
Milestone
v0.42
Development

Successfully merging this pull request may close these issues.

bug: CustomStreamMap always convert datetime field to date
1 participant
@edgarrmondragon