Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix RoleBinding and namespace in samples #80

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

rustycl0ck
Copy link
Contributor

What this PR does / Why we need it

  • Add namespace to new version samples
  • Fix RoleBinding subject kind (the provided subject is actually a Role and not a CluserRole)
  • Install cert-manager by default when Kind cluster is reset

Which issue(s) this PR fixes

Fixes #

@rustycl0ck rustycl0ck requested a review from a team as a code owner March 9, 2022 08:57
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustycl0ck rustycl0ck merged commit 03357c3 into mercari:master Mar 10, 2022
rustycl0ck added a commit to rustycl0ck/spanner-autoscaler that referenced this pull request Mar 10, 2022
Signed-off-by: rustyclock <rustyclock@protonmail.com>
rustycl0ck added a commit to rustycl0ck/spanner-autoscaler that referenced this pull request Apr 20, 2022
Signed-off-by: rustyclock <rustyclock@protonmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants