Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix RoleBinding and namespace in samples #80

Merged
merged 1 commit into from
Mar 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ kind-cluster-create: kind ## Create a kind cluster for development
@if [ -z $(shell $(KIND) get clusters | grep $(KIND_CLUSTER_NAME)) ]; then \
$(KIND) create cluster --name $(KIND_CLUSTER_NAME); \
fi
## Change context to use kind cluster as default
kubectl config use-context kind-$(KIND_CLUSTER_NAME)
## Install cert-manager for generating certifacetes for validation and defaulting webhooks
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.6.1/cert-manager.yaml

kind-cluster-delete: kind ## Delete the kind cluster created for development
@$(KIND) delete cluster --name $(KIND_CLUSTER_NAME)
Expand Down
2 changes: 1 addition & 1 deletion config/samples/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ metadata:
namespace: test
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
kind: Role
name: spanner-autoscaller-secret-reader
subjects:
- kind: ServiceAccount
Expand Down
1 change: 1 addition & 0 deletions config/samples/spanner_v1beta1_spannerautoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: spanner.mercari.com/v1beta1
kind: SpannerAutoscaler
metadata:
name: spannerautoscaler-sample-beta
namespace: test
spec:
targetInstance:
projectId: beta-project
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: spanner.mercari.com/v1beta1
kind: SpannerAutoscaleSchedule
metadata:
name: spannerautoscaleschedule-sample
namespace: test
spec:
targetResource: spannerautoscaler-sample-beta
additionalProcessingUnits: 300
Expand Down