Allow custom tags & update consistence/coding-standard #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojgr
changed the title
hojgr
force-pushed
the
allow-custom-tags
branch
from
064bb14 to
ef79437
Compare
Yaml parser does not allow custom tags by default, but custom tags are needed to use Symfony's shortcut to injecting tagged services https://symfony.com/doc/current/service_container/tags.html#reference-tagged-services Lowest symfony/yaml that support the custom tags is 3.3, thus I updated the requirements too
hojgr
force-pushed
the
allow-custom-tags
branch
from
ef79437 to
2774f38
Compare
|
fixed the build errors by updating symfony/yaml |
|
Is this repo maintained or is it perhaps dead? |
|
@hojgr for some reason I'm not getting e-mail notification for my own repositories so I discovered this PR by accident. Thanks for the PR. Merged and released as 1.3.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yaml parser does not allow custom tags by default, but custom tags
are needed to use Symfony's shortcut to injecting tagged services
https://symfony.com/doc/current/service_container/tags.html#reference-tagged-services
Lowest symfony/yaml that support the custom tags is 3.1, thus I updated the requirements too
This PR also updates consistence/coding-standard to make this package buildable with php 7.3