-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[#2042] Changed convo infrastructure to use Web Sockets. #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2020
tonyanziano
commented
Jan 9, 2020
tonyanziano
commented
Jan 9, 2020
srinaath
requested changes
Jan 9, 2020
packages/app/client/src/ui/editor/emulator/emulatorContainer.ts
Outdated
Show resolved
Hide resolved
packages/app/main/src/server/routes/channel/conversations/handlers/createConversation.ts
Outdated
Show resolved
Hide resolved
packages/app/main/src/server/routes/emulator/handlers/updateConversation.ts
Show resolved
Hide resolved
packages/app/main/src/server/routes/emulator/handlers/updateConversation.ts
Outdated
Show resolved
Hide resolved
960a6d0
to
c026480
Compare
c026480
to
b627ece
Compare
I think the coverage number has gone down as a result of removing a lot of tested code, but I will try to write some more to lessen the drop. |
Opened another PR with a bunch of new tests to compensate for drop in code coverage: |
srinaath
previously approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments or nice to have's.. Looks awesome 👍
packages/app/client/src/ui/editor/emulator/parts/chat/chat.spec.tsx
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1405 , #2042
===
Highlights
emulator.tsx
componentbotSagas.ts
andchatSagas.ts
so now they can be called more declaratively instead of relying on changes to props satisfying the right criteria.chat
file versus a.transcript
file.chat
file, we first usechatdown
to convert the file to a transcript before extracting the activitiesSetCurrentUser
command and manually maintaining the stateusers
property from persistedserver.json
file (no more endless list of randomly generated user IDs from previous sessions)Passing E2E tests:
Diagram of High-level Changes