Skip to content

Gracefully handle errors where 'typings' is not a string (fixes #4828) #5971

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 7, 2015

Conversation

pimterry
Copy link
Contributor

@pimterry pimterry commented Dec 7, 2015

Rather than blindly assuming 'typings' is a string (and exploding when it's not), we now check, and gracefully move on it not.

I've avoided throwing exceptions if the type of this is incorrect, and instead quietly ignoring it. I'm a bit hesitant about that, but it's consistent with what we do in various other cases for this. If the package.json is unreadable or doesn't contain JSON, for example, we currently silently ignore that and move on too.

@msftclas
Copy link

msftclas commented Dec 7, 2015

Hi @pimterry, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Dec 7, 2015

@pimterry, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@vladima
Copy link
Contributor

vladima commented Dec 7, 2015

👍

mhegazy added a commit that referenced this pull request Dec 7, 2015
Gracefully handle errors where 'typings' is not a string (fixes #4828)
@mhegazy mhegazy merged commit a405afd into microsoft:master Dec 7, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Dec 7, 2015

thanks @pimterry!

@pimterry pimterry deleted the typings-non-string branch July 26, 2017 16:21
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants