Gracefully handle errors where 'typings' is not a string (fixes #4828) #5971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than blindly assuming 'typings' is a string (and exploding when it's not), we now check, and gracefully move on it not.
I've avoided throwing exceptions if the type of this is incorrect, and instead quietly ignoring it. I'm a bit hesitant about that, but it's consistent with what we do in various other cases for this. If the package.json is unreadable or doesn't contain JSON, for example, we currently silently ignore that and move on too.