Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ARM Deployment Task-Error for Bicep File Paths(#16789) #19382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

venkymanda
Copy link

@venkymanda venkymanda commented Dec 14, 2023

Task name: AzureResourceManagerTemplateDeploymentV3

Description: To fix ARM Template deployment Task fails for bicep files when the path includes spaces
Documentation changes required: (N)
Added unit tests: (N)

Attached related issue: (Y) [https://github.com//issues/16789]

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@venkymanda
Copy link
Author

@microsoft-github-policy-service agree

@trolleyboy
Copy link

@manolerazvan / @rvairavelu - can this PR be reviewed please? This issue with the ARM Deployment task not supporting spaces in bicep folder paths is super frustrating.

Copy link
Contributor

@manolerazvan manolerazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the version to current branch please

@v-mohithgc
Copy link
Contributor

v-mohithgc commented Apr 22, 2024

Hi @venkymanda, thanks for creating this PR, I noticed there are few conflicts and also build wasn't completed.
In order to unblock PR checks, you need to bump the task minor version to 239, need to build these changes locally and later commit the changes.
So, for that, you can follow the below steps: (till step 2)

Have the code changes ready (checkout to this branch), navigate to task root path ie C:...\azure-pipelines-tasks
Note: tfx build works only on node 8 and 10, so make sure to use node 8/10 while testing the task

Step 1: run "npm i"

Step 2: Build:

node make.js build --task AzureResourceManagerTemplateDeploymentV3

//Optional for local testing
Step 3: Install tfx:

npm install -g tfx-cli

Step 4: Login:

tfx login
Service URL : [your task test org url]
PAT :

Step 5: Upload:

tfx build tasks upload --task-path C:\AzurePipelineTask\azure-pipelines-tasks\
_build\Tasks\AzureResourceManagerTemplateDeploymentV3

New task version will be uploaded to your org, please test the changes by running the pipeline.

Step 6: Delete: // optional and can be done after all the testing is completed.

tfx build tasks delete --task-id { }

@thommaa
Copy link

thommaa commented Jun 26, 2024

updated PR existing here #20048

@thommaa
Copy link

thommaa commented Jul 29, 2024

@manolerazvan please close / abandon this PR as there is a PR with unit tests and quotes around the path with file extension appended #20048 available and ready for merge.
Highly appreciated.

@venkymanda
Copy link
Author

@v-mohithgc thank you let me do that

@thommaa
Copy link

thommaa commented Sep 5, 2024

@manolerazvan / @rvairavelu - This #16789 with the ARM Deployment task not supporting spaces in bicep folder paths is super frustrating.
Please close / abandon this PR as there is a PR with unit tests and quotes around the path with file extension appended #20048 available.
Highly appreciated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants