Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(16789): allow whitespace in bicep deployment file paths #20048

Conversation

jupjohn
Copy link

@jupjohn jupjohn commented Jun 21, 2024

Task name: AzureResourceManagerTemplateDeploymentV3

Description: Allow bicep template file paths to contain spaces

Documentation changes required: (N)

Added unit tests: (Y)

Attached related issue: (Y) #16789 (and would supersede #19382)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected I haven't been able to confirm this due to many (many) publish & test environment issues. I'm relying on the pipeline to let me know if the tests run as I've spent too long just trying to get any of them to pass from mainline

@jupjohn jupjohn requested review from manolerazvan and a team as code owners June 21, 2024 04:14
@jupjohn
Copy link
Author

jupjohn commented Jun 21, 2024

@microsoft-github-policy-service agree

@thommaa
Copy link

thommaa commented Jun 26, 2024

@manolerazvan please proceed here to have the pipelines run.

@jupjohn
Copy link
Author

jupjohn commented Jul 29, 2024

@manolerazvan I appreciate that this is probably low-priority for you, but when you've got some time could you review this PR please? We've run into this issue inside of my organisation a few times since and are keen to get this merged.

@jupjohn
Copy link
Author

jupjohn commented Sep 19, 2024

Closing as superseded by #20426

@jupjohn jupjohn closed this Sep 19, 2024
@jupjohn jupjohn deleted the fix/16789-escape-bicep-deployment-file-paths branch September 19, 2024 03:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants