Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes UI view #3561

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Fixes UI view #3561

merged 7 commits into from
Oct 23, 2023

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Oct 17, 2023 •
edited
Loading

Description

Fixes UI feature.
Only activate MVC View options if UI is enabled.

Related issues

Addresses [issue #].

Testing

Manual: Change, the following to true, then hit a url with the web browser /Patient

fhir-server/src/Microsoft.Health.Fhir.Shared.Web/appsettings.json

Line 20 in b376cef

"SupportsUI": false,

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@brendankowitz brendankowitz requested a review from a team as a code owner October 17, 2023 21:06
@brendankowitz brendankowitz added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Oct 19, 2023
@brendankowitz brendankowitz added this to the S126 milestone Oct 19, 2023
PTaladay
PTaladay previously approved these changes Oct 19, 2023
View reviewed changes
@brendankowitz brendankowitz mentioned this pull request Oct 20, 2023
Closed
1 task
@brendankowitz brendankowitz force-pushed the personal/bkowitz/fix-ui-feature branch from 342ff9d to b4838c7 Compare October 20, 2023 18:06
brendankowitz
brendankowitz commented Oct 20, 2023
View reviewed changes
src/Microsoft.Health.Fhir.Shared.Api/Features/Formatters/HtmlOutputFormatter.cs

var actionContext = new ActionContext(context.HttpContext, context.HttpContext.GetRouteData(), new ActionDescriptor());

using (TextWriter textWriter = context.WriterFactory(context.HttpContext.Response.Body, selectedEncoding))
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main changes to this file was un-nesting usings, and adding AllowSynchronousIO();

mikaelweave
mikaelweave approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - had no idea this existed. Cool. 😄

@v-iyamauchi v-iyamauchi merged commit a3bb92b into main Oct 23, 2023
@v-iyamauchi v-iyamauchi deleted the personal/bkowitz/fix-ui-feature branch October 23, 2023 15:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikaelweave mikaelweave mikaelweave approved these changes

@fhibf fhibf fhibf approved these changes

@PTaladay PTaladay PTaladay left review comments

Assignees
No one assigned
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Milestone
S126
Development

Successfully merging this pull request may close these issues.
5 participants
@brendankowitz @mikaelweave @fhibf @PTaladay @v-iyamauchi