Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changing AddFhirServer with an optional parameter for MVC. #3566

Closed
wants to merge 3 commits into from

Conversation

v-iyamauchi
Copy link
Contributor

@v-iyamauchi v-iyamauchi commented Oct 19, 2023

Description

Changing AddFhirServer with an optional parameter for whether to register ASP.NET MVC components. It is an alternative way to ignoring a DI related exception from the generic host startup in the worker stateless base class in common-package.

Related issues

Addresses [issue #110300].

Bug 110300: Unable to resolve service for type 'Microsoft.AspNetCore.Hosting.IWebHostEnvironment' while attempting to activate 'Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.MvcRazorRuntimeCompilationOptionsSetup'

Testing

Will be tested in the health-paas CI pipeline.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-iyamauchi v-iyamauchi added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Oct 19, 2023
@v-iyamauchi v-iyamauchi added this to the S126 milestone Oct 19, 2023
@brendankowitz
Copy link
Member

This should now be fully addressed by: #3561

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants