Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

impact:non-functional label logic is inversed #47

Closed
makubacki opened this issue Dec 2, 2022 · 0 comments · Fixed by #48
Closed

impact:non-functional label logic is inversed #47

makubacki opened this issue Dec 2, 2022 · 0 comments · Fixed by #48
Assignees
@makubacki
Labels
type:bug Something isn't working

Comments

@makubacki
Copy link
Member

PRs present options that automatically apply labels to the PR.

Example:
image

The "Impacts functionality?" box currently applies the impact:non-functional label if checked. The logic needs to be inverted to be correct.
@makubacki makubacki added the type:bug Something isn't working label Dec 2, 2022
@makubacki makubacki self-assigned this Dec 2, 2022
@makubacki makubacki mentioned this issue Dec 2, 2022
Merged
makubacki added a commit that referenced this issue Dec 3, 2022
@makubacki
label-issues: Invert functional impact label logic (#48)
729de2b 
Fixes #47 

The checkbox exposed to contributors in a PR to determine whether
the PR has a functional impact states:

"Impacts functionality?"

This uses positive logic to simplify understanding by the user.

Currently the `impact:non-functional` label is applied if the
checkbox is checked.

This change inverts the logic to apply the label as expected.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@makubacki makubacki

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

label-issues: Invert functional impact label logic makubacki/mu_devops
1 participant
@makubacki