label-issues: Invert functional impact label logic #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkbox exposed to contributors in a PR to determine whether the PR has a functional impact states: "Impacts functionality?" This uses positive logic to simplify understanding by the user. Currently the `impact:non-functional` label is applied if the checkbox is checked. This change inverts the logic to apply the label as expected. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
apop5
approved these changes
Dec 2, 2022
cfernald
approved these changes
Dec 2, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
The checkbox exposed to contributors in a PR to determine whether
the PR has a functional impact states:
"Impacts functionality?"
This uses positive logic to simplify understanding by the user.
Currently the
impact:non-functionallabel is applied if thecheckbox is checked.
This change inverts the logic to apply the label as expected.
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com