refactor: replace directory substitution plugin with condition_script_runner_args #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_directory-substitution plugin with condition_script_runner_args
wmmc88
approved these changes
Sep 3, 2024
NateD-MSFT
approved these changes
Sep 4, 2024
hamzamust
approved these changes
Sep 5, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171
With the recent merge of Expand condition_script_runner_args #1132 the
rust-condition-script-cargo_make_current_task_initial_makefile_directory-substitutionplugin is no longer needed. Thecondition_script_runner_argsallows directly passing base path to the condition script runner. This PR updates the implementation by replacing the plugin with thecondition_script_runner_args.