Expand condition_script_runner_args

[wmmc88]

#1081 added condition_script_runner_args, but condition_script_runner_args didn't expand env vars like script_runner_args did. This PR adds env expansion to condition_script_runner_args, and also adds tests for it.

Various bugfixes to tests were also fixed in order for cargo make ci-flow to pass on:

1. windows computers
2. environments that set CARGO_HOME

[sagiegurari]

@wmmc88 thanks for the PR! would love if you see my comment

[wmmc88]

@wmmc88 thanks for the PR! would love if you see my comment

@sagiegurari I've updated the PR so that there is no change in env when condition evaluation fails (and added a test to prevent possible future regressions)

[wmmc88]

@sagiegurari friendly ping to review this :) the underlying bug is a blocker for me

[sagiegurari]

@wmmc88 sorry for the delay! i'll go over it today

[sagiegurari]

@wmmc88 everything looks pretty great just 2 main thinigs

1. docs - the file is generated so your changes will be deleted. lets try not to do the nav changes you did but only the content. you can add nav, but not add a new root please.
2. env setup before the condition and restoring it causes new env vars defined in the task to stick even if condition fails. we need to remove them.

[codecov]

Codecov Report

Attention: Patch coverage is 19.78022% with 73 lines in your changes missing coverage. Please review.

Project coverage is 69.01%. Comparing base (6193a27) to head (092fea3).
Report is 18 commits behind head on master.

Files	Patch %	Lines
src/lib/runner_test.rs	0.00%	51 Missing ⚠️
src/lib/environment/mod_test.rs	0.00%	21 Missing ⚠️
src/lib/environment/mod.rs	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1132       +/-   ##
===========================================
- Coverage   92.81%   69.01%   -23.80%     
===========================================
  Files         119      119               
  Lines       26224    26347      +123     
===========================================
- Hits        24339    18183     -6156     
- Misses       1885     8164     +6279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wmmc88]

@sagiegurari I think I've resolved all your requested changes

[sagiegurari]

Thanks a lot @wmmc88 for the PR. merged.
I'll probably release a new version at end of week.
sorry it took so long.

[wmmc88]

Thanks a lot @wmmc88 for the PR. merged. I'll probably release a new version at end of week. sorry it took so long.

Hi @sagiegurari! friendly bump for a release

[sagiegurari]

@wmmc88 sorry for really late handling of this but 0.37.16 is now released with this fix. thanks for the pr