Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NationalSecurityAgency.Ghidra 10.3.3 #119124

Closed
wants to merge 2 commits into from

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Sep 7, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 8, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.) ---
System.ComponentModel.Win32Exception (216): The specified executable is not a valid application for this OS platform.
--- End of stack trace from previous location where exception was thrown --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 8, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 8, 2023
@microsoft-github-policy-service
Copy link
Contributor

chausner,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@chausner
Copy link
Contributor Author

chausner commented Sep 8, 2023

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.) ---
System.ComponentModel.Win32Exception (216): The specified executable is not a valid application for this OS platform.
--- End of stack trace from previous location where exception was thrown --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

I think this is because the command is not an executable but a batch file (ghidra_10.3.3_PUBLIC\ghidraRun.bat) which invokes the Java runtime. The application is a Java application so there is no Win32 executable.

Is there a way to still make this work? When I install it locally, the ghidra command works as expected.

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 9, 2023

Automatic Validation ended with:

Exception during executable launch operation System.AggregateException: One or more errors occurred. (The specified executable is not a valid application for this OS platform.) ---
System.ComponentModel.Win32Exception (216): The specified executable is not a valid application for this OS platform.
--- End of stack trace from previous location where exception was thrown --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)

I think this is because the command is not an executable but a batch file (ghidra_10.3.3_PUBLIC\ghidraRun.bat) which invokes the Java runtime. The application is a Java application so there is no Win32 executable.

Is there a way to still make this work? When I install it locally, the ghidra command works as expected.

Edit: I thought this package was already part of our public manifests, but apparently it's not. We should probably get @denelon's approval, since I believe BAT files aren't supported.

@stephengillie stephengillie added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 9, 2023
@denelon
Copy link
Contributor

denelon commented Sep 9, 2023

Batch files aren't a supported type.

@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 9, 2023
@stephengillie stephengillie removed Validation-Completed Validation passed Needs-Attention This work item needs to be reviewed by a member of the core team. Waived-Validation-Executable-Error labels Sep 11, 2023
@denelon denelon closed this Jan 2, 2024
auto-merge was automatically disabled January 2, 2024 20:00

Pull request was closed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants