Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose Skip exception #415

Closed
Khady opened this issue Dec 21, 2024 · 1 comment · Fixed by #416
Closed

Expose Skip exception #415

Khady opened this issue Dec 21, 2024 · 1 comment · Fixed by #416

Comments

@Khady
Copy link
Contributor

Khady commented Dec 21, 2024 •
edited
Loading

For ocaml-junit support of alcotest it is necessary to catch the Alcotest_engine.V1.Core.Skip exception to detect tests which are skipped.

https://github.com/Khady/ocaml-junit/pull/10/files#diff-8485feec8501e5d458218068a62dcc2de7a7ea65f0f718f7798bcf097d1ac657R37-R42

So far this exception is not officially exposed, even though it can be accessed through Alcotest_engine__core.
@Khady Khady mentioned this issue Dec 21, 2024
Closed
@Khady
Copy link
Contributor Author

Khady commented Dec 22, 2024

Introduced by #368

@Khady Khady mentioned this issue Dec 23, 2024
Merged
@samoht samoht mentioned this issue Mar 13, 2025
Merged
samoht added a commit to samoht/opam-repository that referenced this issue Mar 13, 2025
@samoht
[new release] alcotest (5 packages) (1.9.0)
4bb6e5f 
CHANGES:

- Add `seq`, a testable for `Seq.t` and `contramap` (mirage/alcotest#412 @xvw)
- Expose the `V1.Skip` exception (mirage/alcotest#415, mirage/alcotest#416, @Khady)
- BREAKING FIX: `match_raises` now expects the user-defined function to return
  true for expected exceptions. Previously false was interpreted as an
  expected exception. (mirage/alcotest#418, mirage/alcotest#419, @psafont)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

engine: expose skip exception Khady/alcotest
1 participant
@Khady