engine: expose skip exception #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
commented
Dec 23, 2024
| @@ -268,4 +268,4 @@ let match_raises ?here ?pos msg exnp f = | |||
| Fmt.pf ppf "%t%a %s: got %a." (pp_location ?here ?pos) Pp.tag `Fail | |||
| msg Fmt.exn e) | |||
|
|
|||
| let skip () = raise Core.Skip | |||
| let skip () = raise Core.V1.Skip | |||
There was a problem hiding this comment.
I wasn't too sure if test.ml was suppose to depend on V1 or not.
There was a problem hiding this comment.
yea that's a bit odd and seems unrelated with the rest of the changes?
samoht
force-pushed
the
louis/expose-skip
branch
from
2c0a936 to
0759dfb
Compare
|
The lower bound issue should be fixed by ocaml/opam-repository#27616 |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Mar 13, 2025
CHANGES: - Add `seq`, a testable for `Seq.t` and `contramap` (mirage/alcotest#412 @xvw) - Expose the `V1.Skip` exception (mirage/alcotest#415, mirage/alcotest#416, @Khady) - BREAKING FIX: `match_raises` now expects the user-defined function to return true for expected exceptions. Previously false was interpreted as an expected exception. (mirage/alcotest#418, mirage/alcotest#419, @psafont)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #415