Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Reset Model::$unset when a model is saved or refreshed #2709

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Reset Model::$unset when a model is saved or refreshed #2709

merged 3 commits into from
Jan 17, 2024

Conversation

richardfila
Copy link
Contributor

@richardfila richardfila commented Jan 15, 2024 •
edited by GromNaN
Loading

Fix #2708

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@richardfila richardfila mentioned this pull request Jan 15, 2024
Closed
@GromNaN GromNaN changed the base branch from 4.1 to 4.0 January 15, 2024 21:43
@GromNaN
Copy link
Member

GromNaN commented Jan 16, 2024

Hello @richardfila, thanks for working on this fix. Could you add a test case in ModelTest to prevent regression on this feature?

@GromNaN GromNaN changed the title Fix issue #2708 introduced in #2578 Reset Model::$unset when a model is saved or refreshed Jan 17, 2024
@GromNaN GromNaN merged commit da11d4d into mongodb:4.0 Jan 17, 2024
@GromNaN
Copy link
Member

GromNaN commented Jan 17, 2024

Thank you @richardfila

@richardfila
Copy link
Contributor Author

Hello @richardfila, thanks for working on this fix. Could you add a test case in ModelTest to prevent regression on this feature?

Thanks for finishing the testing Jérôme.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardfila @GromNaN