Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reset Model::$unset when a model is saved or refreshed #2709

Merged
merged 3 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Changelog
All notable changes to this project will be documented in this file.

## [4.0.3] - unreleased
## [4.0.3] - 2024-01-17

- Reset `Model::$unset` when a model is saved or refreshed [#2709](https://github.com/mongodb/laravel-mongodb/pull/2709) by [@richardfila](https://github.com/richardfila)

## [4.0.2] - 2023-11-03

Expand Down
26 changes: 26 additions & 0 deletions src/Eloquent/Model.php
Original file line number Diff line number Diff line change
Expand Up @@ -614,4 +614,30 @@ protected function addCastAttributesToArray(array $attributes, array $mutatedAtt

return $attributes;
}

/**
* {@inheritDoc}
*/
public function save(array $options = [])
{
$saved = parent::save($options);

// Clear list of unset fields
$this->unset = [];

return $saved;
}

/**
* {@inheritDoc}
*/
public function refresh()
{
parent::refresh();

// Clear list of unset fields
$this->unset = [];

return $this;
}
}
15 changes: 15 additions & 0 deletions tests/ModelTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,10 @@ public function testUnset(): void
$user1->unset('note1');

$this->assertFalse(isset($user1->note1));
$this->assertTrue($user1->isDirty());

$user1->save();
$this->assertFalse($user1->isDirty());

$this->assertFalse(isset($user1->note1));
$this->assertTrue(isset($user1->note2));
Expand Down Expand Up @@ -526,6 +528,19 @@ public function testUnset(): void
$this->assertFalse(isset($user2->note2));
}

public function testUnsetRefresh(): void
{
$user = User::create(['name' => 'John Doe', 'note' => 'ABC']);
$user->save();
$user->unset('note');
$this->assertTrue($user->isDirty());

$user->refresh();

$this->assertSame('ABC', $user->note);
$this->assertFalse($user->isDirty());
}

public function testUnsetAndSet(): void
{
$user = User::create(['name' => 'John Doe', 'note1' => 'ABC', 'note2' => 'DEF']);
Expand Down