Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file #2751

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file #2751

merged 1 commit into from
Mar 19, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Mar 18, 2024 •
edited
Loading

Description

With the addition of moveit/moveit_resources#198, the YAML equivalence tests in the moveit_setup_controllers package was failing. So this adds that line to the exported configs, which is probably a good default if we want users to use MoveIt Servo easily.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass self-assigned this Mar 18, 2024
@sea-bass sea-bass mentioned this pull request Mar 18, 2024
Closed
6 tasks
@sea-bass sea-bass changed the title Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file Mar 18, 2024
@henningkayser henningkayser merged commit 281efe8 into main Mar 19, 2024
7 of 12 checks passed
@henningkayser henningkayser deleted the allow-nonzero-vel-traj-msa branch March 19, 2024 14:08
@sea-bass sea-bass added the backport-iron Mergify label that triggers a PR backport to Iron label Nov 16, 2024
mergify bot pushed a commit that referenced this pull request Nov 16, 2024
@sea-bass @mergify
Add allow_nonzero_velocity_at_trajectory_end parameter to exported ro…
0563a72 
…s2_controllers config file (#2751)

(cherry picked from commit 281efe8)
@mergify mergify bot mentioned this pull request Nov 16, 2024
Merged
6 tasks
sea-bass added a commit that referenced this pull request Nov 16, 2024
@mergify @sea-bass
Add allow_nonzero_velocity_at_trajectory_end parameter to exported ro…
b094539 
…s2_controllers config file (#2751) (#3109)

(cherry picked from commit 281efe8)

Co-authored-by: Sebastian Castro <4603398+sea-bass@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjahr sjahr sjahr approved these changes

@henningkayser henningkayser henningkayser approved these changes

@AndyZe AndyZe Awaiting requested review from AndyZe

Assignees

@sea-bass sea-bass

Labels
backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sea-bass @henningkayser @sjahr