Allow nonzero velocity at trajectory end for ros2_controllers #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
rolling is broken now likely because of the upcoming 24.04 sync, but I think we can go ahead here |
sjahr
approved these changes
Mar 11, 2024
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing moveit/moveit2#2733, I noticed that this was now needed for our servo configs if we are using the acceleration limited plugin.
This has been needed since November 2023 for this use case: ros-controls/ros2_controllers#834, noting the parameter only exists on Rolling, and not on Humble.
cc @ibrahiminfinite