This repository has been archived by the owner on May 22, 2021. It is now read-only.
_blank all footer links #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually its the d metrics that break it... |
dannycoates
force-pushed
the
footer-link-blank
branch
from
1d688bf to
9533afb
Compare
pdehaan
reviewed
Aug 3, 2017
| <a href="https://testpilot.firefox.com/about" data-l10n-id="footerLinkAbout" target="_blank">About Test Pilot</a> | ||
| <a href="/legal" data-l10n-id="footerLinkPrivacy" target="_blank">Privacy</a> | ||
| <a href="/legal" data-l10n-id="footerLinkTerms" target="_blank">Terms</a> | ||
| <a href="https://www.mozilla.org/privacy/websites/#cookies" data-l10n-id="footerLinkCookies" target="_blank">Cookies</a> |
There was a problem hiding this comment.
If we're going to go down the rabbit hole, do we also need to adjust the logo+wordmark, Test Pilot link, and feedback links in the header?
There was a problem hiding this comment.
The only one without it now is the Send logo. I'd kinda like to keep it like that
dannycoates
force-pushed
the
footer-link-blank
branch
from
9533afb to
376e1ef
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YOLO
ref #398