Adds higher order functions for elm #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Can you please link me to a working online Elm playground with your code? I'm getting |
|
Oops! Sorry about that. I took a look at what you had and updated it. Check out https://ellie-app.com/3BnbfbnwnXYa1 for a compiling example. |
mtso
reviewed
Oct 13, 2018
| @@ -0,0 +1,31 @@ | |||
| module Elm exposing (main) | |||
|
|
|||
| import Html | |||
There was a problem hiding this comment.
Can you update the imports to explicitly expose the imported identifiers?
import Html exposing (Html, text, div)
import String exposing (fromInt)
import List
|
Just the imports and it looks good to go :) |
BenBals
added a commit
to BenBals/hof
that referenced
this pull request
Oct 9, 2019
This improves on mtso#12 to address the concerns about imports you mentioned and use the new Browser API.
Merged
|
#18 will be used in lieu of this |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1 for elm.