Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create Elm.elm #18

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Create Elm.elm #18

merged 4 commits into from
Oct 10, 2019

Conversation

BenBals
Copy link
Contributor

@BenBals BenBals commented Oct 9, 2019

This improves on #12 to address the concerns about imports you mentioned and use the new Browser API.

This improves on mtso#12 to address the concerns about imports you mentioned and use the new Browser API.
@mtso
Copy link
Owner

mtso commented Oct 9, 2019

Couldn't get it to compile until I changed the module name to Main: https://ellie-app.com/6SxcJHH6mpva1
Can you update the module name so that it will compile and run with an Elm online environment? (if not ellie-app, can you link it here please?)

@BenBals
Copy link
Contributor Author

BenBals commented Oct 10, 2019

Sure, thanks for the feedback! I hope you agree with the changes made.

@mtso
Copy link
Owner

mtso commented Oct 10, 2019

looks good, thank you for your contribution!!

@mtso mtso merged commit 4710797 into mtso:master Oct 10, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants