Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

library files contains shebangs (they should not). #171

Closed
leamas opened this issue Apr 2, 2018 · 2 comments
Closed

library files contains shebangs (they should not). #171

leamas opened this issue Apr 2, 2018 · 2 comments

Comments

@leamas
Copy link
Contributor

leamas commented Apr 2, 2018 •
edited
Loading

As heading says: The files in the mkchromecast directory contains shebangs like #/usr/bin/env python. This is plain wrong, they are not executed as stand-alone units.

The exception is mkchromecast.py. handled in #166 by moving to separate dir.

The shebangs looks innocent, but causes packaging noise and should better be removed

EDIT: typos
@leamas
Copy link
Contributor Author

leamas commented Apr 4, 2018

A patch is available at https://paste.fedoraproject.org/paste/uXQZdie0CWRuvzY4-v9eDw

muammar added a commit that referenced this issue Apr 5, 2018
@muammar
Shebangs were removed. This closes #171. Thanks to @leamas.
6a80837
@muammar muammar closed this as completed Apr 5, 2018
@muammar
Copy link
Owner

muammar commented Apr 5, 2018

@leamas thanks!.

muammar added a commit that referenced this issue Apr 24, 2018
@muammar
Merge branch 'devel' into ui
ae96969 
* devel:
  Updated changelog.
  This fixes name 'platform' is not defined when playing youtube videos. It seems to be possible to cast audio only, too. Related to #185.
  devel: Add a .gitattributes, do not export packaging.
  - Updated changelog.md. - README.md updated to match new repo structure.
  nodejs: Remove bundled MacOS binaries.
  nodejs: Remove generated node_modules from repo.
  nodejs: Generate node_modules instead of bundling it (#176).
  Shebangs were removed. This closes #171. Thanks to @leamas.
  setup.py: Add comment on nodejs cruft breaking install (#176).
  setup.py: pydocstyle/pycodestyle fixes.
  setup.py; Simplify using a glob().
  setup.py: Import version instead of fragile parsing.
  setup.py: Kill bad shebang.
  Updated Makefile and setup.py to work with macOS.
  - Updated changelog. - fedora packaging is now in its own branch.
  setup.py: Support linux installations
  Move mkchromecast.py to bin/mkchromecast, shebang fixes.
  Add fedora packaging.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leamas @muammar