Example App v1 #15
Merged
Example App v1 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPReplay_Final1684451130.MP4When I run the app, and tap to upload video, it just takes me to another screen with the same tap to upload video option, but doesn't seem to do anything... |
|
Looks like it's trying to display the permission prompt but can't for some reason. I'll fix that tomorrow |
|
I went ahead and just fixed it now. It should work for you! |
|
Oh, and remember to put your credentials into the fake backend |
|
Cool! I just tested this and it works on my iPhone 🎉 |
| @@ -89,18 +77,51 @@ public final class UploadManager { | |||
| } | |||
| } | |||
|
|
|||
| /// Adds an ``UploadsUpdatedDelegate`` You can add as many of these as you like | |||
| public func addUploadsUpdatedDelegate(_ delegate: (any UploadsUpdatedDelegate)) { | |||
There was a problem hiding this comment.
Suggested change
| public func addUploadsUpdatedDelegate(_ delegate: (any UploadsUpdatedDelegate)) { | |
| public func addUploadsUpdatedDelegate<Delegate: UploadsUpdatedDelegate>(_ delegate: Delegate) { |
There was a problem hiding this comment.
Dropping any here will decrease runtime overhead without any syntactic changes to the call site (i.e. this looks the same either way to clients)
There was a problem hiding this comment.
More on this here if curious: https://www.hackingwithswift.com/swift/5.6/existential-any
Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com>
|
🥳 |
refactornator
added a commit
that referenced
this pull request
May 25, 2023
* Add FakeBackend skeleton * Add the fake backend rest objects * Do the upload backend * Some widgets and colors * Styles or views * Some comments * Add prototype to nav * Ok * Minor indentation fixes * Minor formatting fix * I have mastered your puny buttons * Figuring it out * Ok now we're getting somewhere hypothetically * one last update * Don't need an environment object * Start with the pick flow * I guess we don't need the width * And a little tweaking * Upload CTA can be smarter than this * now for a view model * Move over permission request * Permission Request Success * No crash probs * up * Now to extract a thumbnail * Thumbnail extraction test * Ready to add other states * Error View * Do Processing View * now to hook it up * This thumbnail sucks * Ok now the thumbnail is in at least * Try to post an upload * Working authorization * Add some more headers for the fake backend * Add credentials but the data is off * Fake backend now works * Still works * TODO done * Time to start uploading * Fix bug in forceRestart * come back to that * Progress updates look broken * Fix the upload POST body * Cool regression * Debug * Fix the thumbnail rendering * Now what * Add listener for Uploads Updated * Auto acknowledge uploads * not time for nav * Rearrange the Upload CTA stuff * Updating more stuff * now we're navigating * Figuring it out * Time to start on the upload list * Added more listy stuff * list container * Now it works * Empty list * Hashable * Notify delegates but something doesn't seem to be working * Now working it out * Making it work * Thumbnail in the list items maybe * OK I got it * Figured out thumbnails * Work on it * Work * So far so good * ugh * Making progress * Progress View * Ok * Now we're talking * Ok now we have a status line * Now we are good * Appropriately scope the create-upload viewmodel * Now we are getting to the end * Save old uploads for a while * ont an error * Remove old example UI * cleanup * project * Remove another old UI component * Yknow this isn't really mvvm to begin with * Label cleanup * oh dang forgot the app icon * oh wow that didn't build * Add a Mux Asset catalog * Add Mux assets to a catalog * CTA vis * The list needs to actually scroll * Rename *Screen to *View * Use task instead of onAppear * Don't commit those * Fix permission prompt * AnyObject * Brackets * Update Sources/MuxUploadSDK/Public API/UploadManager.swift Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> * Generics --------- Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com>
daytime-em
added a commit
that referenced
this pull request
May 25, 2023
* NFC: call into upload manager reference (#14) * api: Remove extraneous MIME type and retry time config fields, add opt-out for event tracking (#16) * Remove videoMIMEType and retryBaseTime * Add config option for opt-out * Check opt-out * Report app name as bundle id * doc: Example App v1 (#15) * Add FakeBackend skeleton * Add the fake backend rest objects * Do the upload backend * Some widgets and colors * Styles or views * Some comments * Add prototype to nav * Ok * Minor indentation fixes * Minor formatting fix * I have mastered your puny buttons * Figuring it out * Ok now we're getting somewhere hypothetically * one last update * Don't need an environment object * Start with the pick flow * I guess we don't need the width * And a little tweaking * Upload CTA can be smarter than this * now for a view model * Move over permission request * Permission Request Success * No crash probs * up * Now to extract a thumbnail * Thumbnail extraction test * Ready to add other states * Error View * Do Processing View * now to hook it up * This thumbnail sucks * Ok now the thumbnail is in at least * Try to post an upload * Working authorization * Add some more headers for the fake backend * Add credentials but the data is off * Fake backend now works * Still works * TODO done * Time to start uploading * Fix bug in forceRestart * come back to that * Progress updates look broken * Fix the upload POST body * Cool regression * Debug * Fix the thumbnail rendering * Now what * Add listener for Uploads Updated * Auto acknowledge uploads * not time for nav * Rearrange the Upload CTA stuff * Updating more stuff * now we're navigating * Figuring it out * Time to start on the upload list * Added more listy stuff * list container * Now it works * Empty list * Hashable * Notify delegates but something doesn't seem to be working * Now working it out * Making it work * Thumbnail in the list items maybe * OK I got it * Figured out thumbnails * Work on it * Work * So far so good * ugh * Making progress * Progress View * Ok * Now we're talking * Ok now we have a status line * Now we are good * Appropriately scope the create-upload viewmodel * Now we are getting to the end * Save old uploads for a while * ont an error * Remove old example UI * cleanup * project * Remove another old UI component * Yknow this isn't really mvvm to begin with * Label cleanup * oh dang forgot the app icon * oh wow that didn't build * Add a Mux Asset catalog * Add Mux assets to a catalog * CTA vis * The list needs to actually scroll * Rename *Screen to *View * Use task instead of onAppear * Don't commit those * Fix permission prompt * AnyObject * Brackets * Update Sources/MuxUploadSDK/Public API/UploadManager.swift Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> * Generics --------- Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> * Remove spaces from directory names (for ease of life when scripting) (#18) * Document mux error case * Add doc for muxUploadSDK * Done * more doc * doc just keeps improving" * MuxUpload even nicer docs * Add more doc * Conflict markers * Update Sources/MuxUploadSDK/PublicAPI/MuxUpload.swift Co-authored-by: Liam Lindner <liam@mux.com> * Update Sources/MuxUploadSDK/PublicAPI/UploadManager.swift Co-authored-by: Liam Lindner <liam@mux.com> --------- Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> Co-authored-by: Liam Lindner <liam@mux.com>
Merged
daytime-em
added a commit
that referenced
this pull request
Jun 5, 2023
# API Changes * `MuxUpload`'s initializer no longer requires a MIME type or Retry Time. These are calculated internally * Added methods for querying the `UploadManager` for the list of currenty-active uploads, and listening for changes to the list ## Improvements * NFC: call into upload manager reference (#14) * api: Remove extraneous MIME type and retry time config fields, add opt-out for event tracking (#16) * doc: Add a much-improved example app (#15) ## Fixes * Fix: Uploads continue without reporting progress after being resumed (#24) * Fix: handlers not retained unless callers retain the `MuxUpload` (#25) Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
tomkordic
pushed a commit
that referenced
this pull request
Mar 1, 2024
# API Changes * `MuxUpload`'s initializer no longer requires a MIME type or Retry Time. These are calculated internally * Added methods for querying the `UploadManager` for the list of currenty-active uploads, and listening for changes to the list ## Improvements * NFC: call into upload manager reference (#14) * api: Remove extraneous MIME type and retry time config fields, add opt-out for event tracking (#16) * doc: Add a much-improved example app (#15) ## Fixes * Fix: Uploads continue without reporting progress after being resumed (#24) * Fix: handlers not retained unless callers retain the `MuxUpload` (#25) Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes
API changes were minimal:
UploadManager.acknowledgeUpload(ofFile:)is now internal, and called automatically when an upload is done or canceled (but not when it fails, allowing retries later)UploadManager.addUploadsChangedDelegate()added for UIs that are interested in all in-progress uploads