Fix: handlers not retained unless callers retain the MuxUpload
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
changed the title
MuxUpload
andrewjl-mux
approved these changes
Jun 5, 2023
Merged
daytime-em
added a commit
that referenced
this pull request
Jun 5, 2023
# API Changes * `MuxUpload`'s initializer no longer requires a MIME type or Retry Time. These are calculated internally * Added methods for querying the `UploadManager` for the list of currenty-active uploads, and listening for changes to the list ## Improvements * NFC: call into upload manager reference (#14) * api: Remove extraneous MIME type and retry time config fields, add opt-out for event tracking (#16) * doc: Add a much-improved example app (#15) ## Fixes * Fix: Uploads continue without reporting progress after being resumed (#24) * Fix: handlers not retained unless callers retain the `MuxUpload` (#25) Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
tomkordic
pushed a commit
that referenced
this pull request
Mar 1, 2024
# API Changes * `MuxUpload`'s initializer no longer requires a MIME type or Retry Time. These are calculated internally * Added methods for querying the `UploadManager` for the list of currenty-active uploads, and listening for changes to the list ## Improvements * NFC: call into upload manager reference (#14) * api: Remove extraneous MIME type and retry time config fields, add opt-out for event tracking (#16) * doc: Add a much-improved example app (#15) ## Fixes * Fix: Uploads continue without reporting progress after being resumed (#24) * Fix: handlers not retained unless callers retain the `MuxUpload` (#25) Co-authored-by: AJ Lauer Barinov <102617203+andrewjl-mux@users.noreply.github.com> Co-authored-by: Liam Lindner <liam@mux.com> Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.