-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(editor): Open autocompletion when starting an expression #13249
Merged
ShireenMissi
merged 3 commits into
master
from
node-2398-on-initializing-expression-syntax-pop-up-with-suggestions
Feb 14, 2025
Merged
fix(editor): Open autocompletion when starting an expression #13249
ShireenMissi
merged 3 commits into
master
from
node-2398-on-initializing-expression-syntax-pop-up-with-suggestions
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
ShireenMissi
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
✅ All Cypress E2E specs passed |
n8n
|
Project |
n8n
|
Branch Review |
master
|
Run status |
|
Run duration | 04m 34s |
Commit |
|
Committer | Elias Meire |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
436
|
View all changes introduced in this branch ↗︎ |
Merged
Got released with |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{{
in expression modeRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2398/on-initializing-expression-syntax-pop-up-with-suggestions-not-shown
broken in #13129
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)