Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(editor): Open autocompletion when starting an expression #13249

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Feb 13, 2025

Summary

  • Type {{ in expression mode
  • Brackets should be auto-closed and autocomplete should open
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2398/on-initializing-expression-syntax-pop-up-with-suggestions-not-shown

broken in #13129

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 13, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 14, 2025

n8n    Run #9286

Run Properties:  status check passed Passed #9286  •  git commit 6377635bf0: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #9286
Run duration 04m 34s
Commit git commit 6377635bf0: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 436
View all changes introduced in this branch ↗︎

@ShireenMissi ShireenMissi merged commit 6377635 into master Feb 14, 2025
37 checks passed
@ShireenMissi ShireenMissi deleted the node-2398-on-initializing-expression-syntax-pop-up-with-suggestions branch February 14, 2025 15:09
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants