Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(editor): Fix '=' handling in expressions #13129

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Feb 7, 2025

Summary

  • Typing = in a fixed input should switch to expressions
  • Fix: Typing = in a expression input should insert a = (should not disappear in any case)
  • New: Typing Backspace in an empty expression input switches back to fixed
  • Fix: auto bracket closing should overwrite manually typed closing brackets (instead of duplicating)
  • Cleanup unused code
Screen.Recording.2025-02-07.at.15.27.45.mov

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2176/community-issue-google-sheet-node-removes-the-=-for-formulas
fixes #12194

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 84.14634% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/plugins/codemirror/expressionCloseBrackets.ts 67.85% 9 Missing ⚠️
...neExpressionEditor/InlineExpressionEditorInput.vue 81.81% 2 Missing ⚠️
...ckages/editor-ui/src/components/ParameterInput.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 7, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested manually and it all works as expected except for closing brackets see the screen recording

Screen.Recording.2025-02-07.at.17.03.11.mov

@elsmr elsmr requested a review from ShireenMissi February 10, 2025 10:30
ShireenMissi
ShireenMissi previously approved these changes Feb 10, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 10, 2025

n8n    Run #9207

Run Properties:  status check passed Passed #9207  •  git commit b0ee6fbe8a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-2176-community-issue-google-sheet-node-removes-the-for-formulas
Run status status check passed Passed #9207
Run duration 04m 34s
Commit git commit b0ee6fbe8a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 8f25a06 into master Feb 10, 2025
38 checks passed
@elsmr elsmr deleted the node-2176-community-issue-google-sheet-node-removes-the-for-formulas branch February 10, 2025 15:41
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
@janober
Copy link
Member

janober commented Feb 13, 2025

Got released with n8n@1.79.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheet Node removes the "=" for formulas
3 participants