-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(editor): Fix '=' handling in expressions #13129
fix(editor): Fix '=' handling in expressions #13129
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested manually and it all works as expected except for closing brackets see the screen recording
Screen.Recording.2025-02-07.at.17.03.11.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
|
n8n
|
Project |
n8n
|
Branch Review |
node-2176-community-issue-google-sheet-node-removes-the-for-formulas
|
Run status |
|
Run duration | 04m 34s |
Commit |
|
Committer | Elias Meire |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
435
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
=
in a fixed input should switch to expressions=
in a expression input should insert a=
(should not disappear in any case)Backspace
in an empty expression input switches back to fixedScreen.Recording.2025-02-07.at.15.27.45.mov
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2176/community-issue-google-sheet-node-removes-the-=-for-formulas
fixes #12194
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)