Logging exception handler and fix for stable_log_filename on windows #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although our logger has never thrown in normal conditions, it has been reported to when stressing the RPC in a RAM node, especially with a low rotation file size. This adds an exception handler that handles by simply prints to stderr. Also fixes an issue with the `stable_log_filename` config on Windows. The `node.log` file was being created with read-only permissions, so writing to the file after restarting the node would throw an exception. However, this can't be unit tested because the file gets the full permissions by default. The change to `nano::logging::release_file_sink ()` enables the added test.
clemahieu
previously approved these changes
Aug 13, 2020
…s with read-only on rotation
wezrule
approved these changes
Aug 21, 2020
guilhermelawless
added a commit
that referenced
this pull request
Sep 2, 2020
…2880) * Logging exception handler and fix for stable_log_filename on windows Although our logger has never thrown in normal conditions, it has been reported to when stressing the RPC in a RAM node, especially with a low rotation file size. This adds an exception handler that handles by simply prints to stderr. Also fixes an issue with the `stable_log_filename` config on Windows. The `node.log` file was being created with read-only permissions, so writing to the file after restarting the node would throw an exception. However, this can't be unit tested because the file gets the full permissions by default. The change to `nano::logging::release_file_sink ()` enables the added test. * Set permissions for pre-existing log file as well, as Boost re-creates with read-only on rotation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although our logger has never thrown in normal conditions, it has been reported to when stressing the RPC in a RAM node, especially with a low rotation file size. This adds an exception handler that handles by simply printing to stderr. I could not find a way to test the handler in a unit test.
Also fixes an issue with the
stable_log_filenameconfig on Windows. Thenode.logfile was being created with read-only permissions, so writing to the file after restarting the node would throw an exception. This will be noted in the documentation. However, this also couldn't be unit tested because the file gets the full permissions by default.The change to
nano::logging::release_file_sink ()enables the added test.