Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logging exception handler and fix for stable_log_filename on windows #2880

Commits on Aug 13, 2020

  1. Logging exception handler and fix for stable_log_filename on windows

    Although our logger has never thrown in normal conditions, it has been reported to when stressing the RPC in a RAM node, especially with a low rotation file size. This adds an exception handler that handles by simply prints to stderr.
    
    Also fixes an issue with the `stable_log_filename` config on Windows. The `node.log` file was being created with read-only permissions, so writing to the file after restarting the node would throw an exception. However, this can't be unit tested because the file gets the full permissions by default.
    
    The change to `nano::logging::release_file_sink ()` enables the added test.
    guilhermelawless committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    e5bf356 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Set permissions for pre-existing log file as well, as Boost re-create…

    …s with read-only on rotation
    guilhermelawless committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    d4aee21 View commit details
    Browse the repository at this point in the history