Election scheduler #3208
Merged
Election scheduler #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… * time_since_use based prioritization. The scheduler currently manages two queues. A priority queue where live traffic is managed and scheduled according to vacancy in the active_transactions container and prioritized by the prioritization container. A manual queue where requests that have come through RPCs are enqueued and bypass prioritization.
theohax
previously approved these changes
Apr 19, 2021
This reverts commit 8d3a7e2.
# Conflicts: # nano/node/active_transactions.cpp # nano/node/election.cpp # nano/node/node.cpp # nano/node/vote_processor.cpp # nano/node/wallet.cpp
…is simplifies the election_scheduler commit itself.
# Conflicts: # nano/core_test/active_transactions.cpp # nano/core_test/bootstrap.cpp # nano/core_test/conflicts.cpp # nano/core_test/election.cpp # nano/core_test/ledger.cpp # nano/core_test/network.cpp # nano/core_test/node.cpp # nano/rpc_test/rpc.cpp # nano/slow_test/node.cpp
# Conflicts: # nano/core_test/active_transactions.cpp # nano/core_test/bootstrap.cpp # nano/core_test/conflicts.cpp # nano/core_test/election.cpp # nano/core_test/ledger.cpp # nano/core_test/network.cpp # nano/core_test/node.cpp # nano/rpc_test/rpc.cpp # nano/slow_test/node.cpp
SergiySW
reviewed
Apr 20, 2021
SergiySW
reviewed
Apr 20, 2021
SergiySW
reviewed
Apr 20, 2021
SergiySW
reviewed
Apr 20, 2021
| observe (); | ||
| } | ||
|
|
||
| void nano::election_scheduler::activate (nano::account const & account_a, nano::transaction const & transaction) |
There was a problem hiding this comment.
transaction -> transaction_a ?
Adding thread role name to election scheduler
…he prioritized queue.
SergiySW
previously approved these changes
Apr 22, 2021
# Conflicts: # nano/node/node.cpp
SergiySW
approved these changes
Apr 25, 2021
3 tasks
7 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces PoW-difficulty based prioritization with balance * time_since_use based prioritization. The scheduler currently manages two queues. A priority queue where live traffic is managed and scheduled according to vacancy in the active_transactions container and prioritized by the prioritization container. A manual queue where requests that have come through RPCs are enqueued and bypass prioritization.