Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove elections difficulty sorting #3260

Merged
merged 13 commits into from
May 4, 2021
Merged

Remove elections difficulty sorting #3260

merged 13 commits into from
May 4, 2021

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented May 4, 2021 •
edited
Loading

as a part of switching to time-balance priority (#3208)

Breaking changes:

  • remove active elections ordering & prioritization for already active elections
  • remove active difficulty calculation, RPC "active_difficulty" & websocket "active_difficulty"
  • telemetry returns default difficulty instead of active difficulty
  • remove work watcher & RPC "process" option "watch_work"

@SergiySW
Remove active transactions difficulty sorting (draft in progress)
9976d8a
@SergiySW
Remove active transactions difficulty sorting (draft in progress)
519714f
@SergiySW
Remove active transactions difficulty sorting (draft in progress)
7880f86
@SergiySW
Fix core_test build
bf8de83
@SergiySW
Fix rpc_test & slow_test build
0a3e06b
@SergiySW
Remove "active_difficulty" websocket
a569e2e
@SergiySW
Fix active_transaction.list_active test
844baac
@SergiySW
Merge remote-tracking branch 'upstream/develop' into active/remove_di…
64e8bf4 
…fficulty
@SergiySW
Merge remote-tracking branch 'upstream/develop' into active/remove_di…
115816e 
…fficulty
@SergiySW
Merge remote-tracking branch 'upstream/develop' into active/remove_di…
0842eb4 
…fficulty
@SergiySW
Merge remote-tracking branch 'upstream/develop' into active/remove_di…
d317084 
…fficulty
@SergiySW
Remove "watch_work" enabled control check
99c2db1
@SergiySW SergiySW added documentation This item indicates the need for or supplies updated or expanded documentation websockets rpc refactor removal Indicates functionality is being removed breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. labels May 4, 2021
@SergiySW SergiySW requested a review from clemahieu May 4, 2021 13:00
@SergiySW SergiySW self-assigned this May 4, 2021
@SergiySW SergiySW added this to the V22.0 milestone May 4, 2021
@zhyatt zhyatt linked an issue May 4, 2021 that may be closed by this pull request
Active elections container adjustments #3245
Closed
3 tasks
@clemahieu clemahieu merged commit 9982779 into nanocurrency:develop May 4, 2021
@Joohansson Joohansson mentioned this pull request May 7, 2021
Closed
@zhyatt zhyatt mentioned this pull request May 12, 2021
Closed
SergiySW added a commit to SergiySW/raiblocks that referenced this pull request May 12, 2021
@SergiySW
Remove election restart by difficulty
7b541da 
Leftover after nanocurrency#3260
* additionally fix failing active_transactions.inactive_votes_cache_election_start test (default dev network voters to start election from inactive cache is 2, not 5)

Easier to compare with "Hide whitespace changes"
@SergiySW SergiySW mentioned this pull request May 12, 2021
Merged
SergiySW added a commit that referenced this pull request Jun 14, 2021
@SergiySW
Remove election restart by difficulty (#3280)
c3105a3 
* Remove election restart by difficulty
- Leftover after #3260
- additionally fix failing active_transactions.inactive_votes_cache_election_start test (default dev network voters to start election from inactive cache is 2, not 5)

* Commentary & receive minimum for confirmation_height.gap_live
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

Assignees

@SergiySW SergiySW

Labels
breaking Change to node APIs (separate label) which impacts existing implementation, integrations impacted. documentation This item indicates the need for or supplies updated or expanded documentation removal Indicates functionality is being removed rpc refactor websockets
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.

Active elections container adjustments
2 participants
@SergiySW @clemahieu